aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 35535: Use Shiro identity if available in audit logs.
Date Tue, 16 Jun 2015 21:54:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88136
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java (line 34)
<https://reviews.apache.org/r/35535/#comment140545>

    Should this move to UnsecureSessionContext?


- Joshua Cohen


On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 9:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1352
>     https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use Shiro identity if available in audit logs.
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205

>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35535/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message