aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 35527: Making observer polling interval configurable.
Date Tue, 16 Jun 2015 21:33:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88130
-----------------------------------------------------------



src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py (lines 27 - 30)
<https://reviews.apache.org/r/35527/#comment140542>

    There's a way to set this up so that only these expected properties are accessed, right?
Is it by doing `Mock(spec_set=['root','mesos_root',...])`?
    
    In any event, we should probably do that?


- Joshua Cohen


On June 16, 2015, 8:50 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 8:50 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
>     https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474

>   src/main/python/apache/thermos/observer/task_observer.py b9a37de0f6260dc8c0a6ba92119c57e16f29d82c

>   src/test/python/apache/aurora/BUILD 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py PRE-CREATION

>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> -------
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message