aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Brazil" <brian.bra...@boxever.com>
Subject Re: Review Request 33433: Revert "Revert "Make health check configurable""
Date Wed, 10 Jun 2015 09:05:23 GMT


> On June 9, 2015, 10:08 p.m., Maxim Khutornenko wrote:
> > Please, update RB description to clearly state the history (e.g. commit->revert->re-apply).

Updated.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33433/#review87301
-----------------------------------------------------------


On June 10, 2015, 9:03 a.m., Brian Brazil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33433/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 9:03 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-316
>     https://issues.apache.org/jira/browse/AURORA-316
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This reverts commit d92de5d1862ca694fec3df4f85b8e33c4284dc71, which reverted 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9.
The rollback was due to AURORA-1268, a backwards incompatability in the configuration language,
which is now resolved and released in Aurora 0.8.0.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f 
>   src/main/python/apache/aurora/common/http_signaler.py e3e819d60c28c972a1f8ccdfbfeb03d9e6ca345d

>   src/main/python/apache/aurora/config/schema/base.py a87524a8b3ad5aa0e337e0a0028cecb85865b4e6

>   src/main/python/apache/aurora/executor/common/health_checker.py cfc29c3164837493e4ddfb8314bb6999ddaa0c91

>   src/test/python/apache/aurora/common/test_http_signaler.py f5f8419b42a5484dac78d5a3b5033a7d74b7aa73

>   src/test/python/apache/aurora/executor/common/test_health_checker.py 1b4423a1eb95cc950206a355fa657c8082c8d93f

> 
> Diff: https://reviews.apache.org/r/33433/diff/
> 
> 
> Testing
> -------
> 
> Unittests run.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message