aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 34967: Use TaskStatus Reason to set memory limit message.
Date Wed, 03 Jun 2015 18:13:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34967/
-----------------------------------------------------------

(Updated June 3, 2015, 11:13 a.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
-------

Maxim's feedback.


Bugs: AURORA-1341
    https://issues.apache.org/jira/browse/AURORA-1341


Repository: aurora


Description
-------

Use TaskStatus Reason to set memory limit message instead of checking the contents of the
message field. Future versions of Mesos can change the diagnostic information in the message
field causing Aurora to display no information when a task fails.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 5af691d0ac959cf4b5d01752daf996803e91ed16

  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java fe2fc954350b42487151fc820ebad22a41aeb039


Diff: https://reviews.apache.org/r/34967/diff/


Testing
-------

./gradlew test -Pq


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message