Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C97118F99 for ; Thu, 28 May 2015 00:40:12 +0000 (UTC) Received: (qmail 61958 invoked by uid 500); 28 May 2015 00:40:12 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 61906 invoked by uid 500); 28 May 2015 00:40:12 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 61887 invoked by uid 99); 28 May 2015 00:40:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2015 00:40:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 319B81DDAB8; Thu, 28 May 2015 00:40:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6224656711822414532==" MIME-Version: 1.0 Subject: Re: Review Request 34484: Daemonize all deadline calls in aurora executor. From: "Joe Smith" To: "Vinod Kone" , "Joe Smith" Cc: "Brian Wickman" , "Aurora" Date: Thu, 28 May 2015 00:40:11 -0000 Message-ID: <20150528004011.8660.98173@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joe Smith" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/34484/ X-Sender: "Joe Smith" References: <20150526204345.9497.26906@reviews.apache.org> In-Reply-To: <20150526204345.9497.26906@reviews.apache.org> Reply-To: "Joe Smith" X-ReviewRequest-Repository: aurora --===============6224656711822414532== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/#review85482 ----------------------------------------------------------- Ship it! Ship It! - Joe Smith On May 26, 2015, 1:43 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34484/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 1:43 p.m.) > > > Review request for Aurora, Joe Smith and Vinod Kone. > > > Bugs: AURORA-698 > https://issues.apache.org/jira/browse/AURORA-698 > > > Repository: aurora > > > Description > ------- > > Daemonize all deadline calls in aurora executor. If we do not daemonize, it's possible for the aurora executor to send TASK_KILLED and then block indefinitely on shutdown. This way the aurora executor process will at least exit, allow the cgroup to tear down all active processes. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py df0df0cba3269a137a370e2b4096fd61fd3af258 > > Diff: https://reviews.apache.org/r/34484/diff/ > > > Testing > ------- > > ./pants test src/test/python/apache/aurora/executor:: > > > Thanks, > > Brian Wickman > > --===============6224656711822414532==--