Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6ECA218E02 for ; Thu, 28 May 2015 00:03:47 +0000 (UTC) Received: (qmail 77888 invoked by uid 500); 28 May 2015 00:03:47 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 77838 invoked by uid 500); 28 May 2015 00:03:47 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 77815 invoked by uid 99); 28 May 2015 00:03:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2015 00:03:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CE68E1DDA9B; Thu, 28 May 2015 00:03:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3072734082801531872==" MIME-Version: 1.0 Subject: Review Request 34739: Adding ChainedPathDetector into the GC executor. From: "Maxim Khutornenko" To: "Brian Wickman" , "Zameer Manji" Cc: "Maxim Khutornenko" , "Aurora" Date: Thu, 28 May 2015 00:03:45 -0000 Message-ID: <20150528000345.8660.8587@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/34739/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora --===============3072734082801531872== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34739/ ----------------------------------------------------------- Review request for Aurora, Brian Wickman and Zameer Manji. Bugs: AURORA-1025 https://issues.apache.org/jira/browse/AURORA-1025 Repository: aurora Description ------- This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading. Extracted a method to faciliated unit testing as patching twitter.common.app is not fun. Diffs ----- src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201 src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4 src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88 src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c Diff: https://reviews.apache.org/r/34739/diff/ Testing ------- ./pants test.pytest --no-fast src/test/python:all Thanks, Maxim Khutornenko --===============3072734082801531872==--