Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 260E317C5C for ; Tue, 19 May 2015 23:48:05 +0000 (UTC) Received: (qmail 83511 invoked by uid 500); 19 May 2015 23:48:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 83459 invoked by uid 500); 19 May 2015 23:48:05 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 83435 invoked by uid 99); 19 May 2015 23:48:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 23:48:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C2FEC1DD581; Tue, 19 May 2015 23:48:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2075902933733375296==" MIME-Version: 1.0 Subject: Re: Review Request 34440: Implementing task reconciler. From: "Zameer Manji" To: "Ben Mahler" , "Zameer Manji" , "Kevin Sweeney" Cc: "Maxim Khutornenko" , "Aurora" Date: Tue, 19 May 2015 23:48:03 -0000 Message-ID: <20150519234803.14201.4741@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/34440/ X-Sender: "Zameer Manji" References: <20150519225030.14202.23984@reviews.apache.org> In-Reply-To: <20150519225030.14202.23984@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============2075902933733375296== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84421 ----------------------------------------------------------- Does it make sense for the reconciler to run in parallel with the GC executor mechanism? It seems fine to me, but I would like some re-assurance here. src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java This seems a little hacky, is there a reason why we cannot have an --enable_reconciliation flag? If disabled we can bind TaskReconciler to an implementation that does nothing. src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java Please rename TIME to something that is more representitive of what it holds. src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java Linking to http://mesos.apache.org/documentation/latest/reconciliation/ or briefly explaining what is expected here would be nice. src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java Unrelated to this diff, but can you please explain how the StatusUpdates triggered from `reconcileTasks` are handled? src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java perhaps we should call `executor.shutdownNow` here? src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java How is this related to this diff? - Zameer Manji On May 19, 2015, 3:50 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34440/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 3:50 p.m.) > > > Review request for Aurora, Ben Mahler, Kevin Sweeney, and Zameer Manji. > > > Bugs: AURORA-1047 > https://issues.apache.org/jira/browse/AURORA-1047 > > > Repository: aurora > > > Description > ------- > > Adding a new service to request explict/implicit task reconciliations on a periodic basis. The reconciler is OFF by default until the GC executor code is removed. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java 316ab1c06ce63c9a3f7232264d30a40f487fc45c > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e9d47fda3355786a4e68eac5c28490c04bc68cb3 > src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/mesos/Driver.java 975ea02b45488608286e743888de25862cc77add > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 35cada6160af01c13362fa7c14b9ff8da0300004 > src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 02e87989a17d95d36e61ffcef2e86c91774972bc > src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 2beea4fc1a24c0050898077ecdf6cac2b19fab31 > > Diff: https://reviews.apache.org/r/34440/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============2075902933733375296==--