Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC41A10792 for ; Sun, 10 May 2015 00:13:53 +0000 (UTC) Received: (qmail 33105 invoked by uid 500); 10 May 2015 00:13:53 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 33050 invoked by uid 500); 10 May 2015 00:13:53 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 33032 invoked by uid 99); 10 May 2015 00:13:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2015 00:13:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 50F331DD29E; Sun, 10 May 2015 00:13:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7633787301972713038==" MIME-Version: 1.0 Subject: Re: Review Request 34020: Normalize SLA stat names From: "Aurora ReviewBot" To: "Bill Farner" Cc: "Aurora ReviewBot" , "Joe Smith" , "Aurora" Date: Sun, 10 May 2015 00:13:54 -0000 Message-ID: <20150510001354.1563.67462@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/34020/ X-Sender: "Aurora ReviewBot" References: <20150509215421.1563.87135@reviews.apache.org> In-Reply-To: <20150509215421.1563.87135@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============7633787301972713038== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review83167 ----------------------------------------------------------- Ship it! Master (1c09d58) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 9, 2015, 9:54 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34020/ > ----------------------------------------------------------- > > (Updated May 9, 2015, 9:54 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1282 > https://issues.apache.org/jira/browse/AURORA-1282 > > > Repository: aurora > > > Description > ------- > > Normalize SLA stat names > > This is going to change these metrics from `sla_role/env/job_job_uptime_50.00_sec` to `sla_role_env_job_job_uptime_50_00_sec` > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 > src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 > > Diff: https://reviews.apache.org/r/34020/diff/ > > > Testing > ------- > > [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test > > BUILD SUCCESSFUL > > > Thanks, > > Joe Smith > > --===============7633787301972713038==--