Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BCBD17F0B for ; Fri, 8 May 2015 05:16:40 +0000 (UTC) Received: (qmail 97961 invoked by uid 500); 8 May 2015 05:16:40 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 97912 invoked by uid 500); 8 May 2015 05:16:40 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 97866 invoked by uid 99); 8 May 2015 05:16:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 May 2015 05:16:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1C30D1DD266; Fri, 8 May 2015 05:16:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7462607241996188797==" MIME-Version: 1.0 Subject: Re: Review Request 33778: Adds RPM specfile and support scripting From: "Steve Salevan" To: "Bill Farner" , "Kevin Sweeney" , "Jake Farrell" Cc: "Steve Salevan" , "Aurora" Date: Fri, 08 May 2015 05:16:41 -0000 Message-ID: <20150508051641.1562.5369@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Steve Salevan" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/33778/ X-Sender: "Steve Salevan" References: <20150504193108.20176.96817@reviews.apache.org> In-Reply-To: <20150504193108.20176.96817@reviews.apache.org> Reply-To: "Steve Salevan" X-ReviewRequest-Repository: aurora --===============7462607241996188797== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 4, 2015, 7:31 p.m., Bill Farner wrote: > > We've had success with using vagrant to serve as test beds and build environments for things like this [1]. Docker might be a boon here, as we can use that in ASF's jenkins. > > > > Don't hesitate to punt on this for now, as it's not a ship-blocker for me...but i'm curious if you have any thoughts on this. > > > > > > [1] https://github.com/apache/aurora/blob/master/build-support/python/make-mesos-native-egg > > Jake Farrell wrote: > Though your bash-foo in make-mesos-native-egg is nice I would be a big +1 to using docker for that as well as the packaging (rpm/deb), would love to see both of the packages built that way using something like build-support/docker/${os}/ I agree that Docker might be our best bet, as our next logical step is in figuring out a way to stand up nightly builds and a Yum repo to contain them. To do so we'll want to establish a base Docker image with the necessary BuildRequires for each supported platform (EL 6/7, F19/20/21) and then write a script that'll run through the RPM build procedure and copy the resulting RPMs to some persistent storage, where we can then regenerate the Yum metadata. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82421 ----------------------------------------------------------- On May 8, 2015, 5:08 a.m., Steve Salevan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 5:08 a.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1116 > https://issues.apache.org/jira/browse/AURORA-1116 > > > Repository: aurora > > > Description > ------- > > This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: > > aurora - Aurora Scheduler > aurora-client - Aurora client and admin tool > aurora-thermos - Thermos executor, runner, and observer > aurora-debuginfo - Debugging symbols for Python/libmesos integration > > If you'd like to give it a whirl, the following Make targets will spin up new RPMs: > > make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates > make (release_srpm|release_rpm) - builds without timestamped versioning > > Let me know what you think, and thanks! > > > Diffs > ----- > > packaging/rpm/Makefile PRE-CREATION > packaging/rpm/aurora.init.sh PRE-CREATION > packaging/rpm/aurora.logrotate PRE-CREATION > packaging/rpm/aurora.service PRE-CREATION > packaging/rpm/aurora.spec PRE-CREATION > packaging/rpm/aurora.startup.sh PRE-CREATION > packaging/rpm/aurora.sysconfig PRE-CREATION > packaging/rpm/clusters.json PRE-CREATION > packaging/rpm/thermos-observer.init.sh PRE-CREATION > packaging/rpm/thermos-observer.logrotate PRE-CREATION > packaging/rpm/thermos-observer.service PRE-CREATION > packaging/rpm/thermos-observer.startup.sh PRE-CREATION > packaging/rpm/thermos-observer.sysconfig PRE-CREATION > > Diff: https://reviews.apache.org/r/33778/diff/ > > > Testing > ------- > > Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 > > > Thanks, > > Steve Salevan > > --===============7462607241996188797==--