Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 28A3E1083E for ; Tue, 5 May 2015 22:24:37 +0000 (UTC) Received: (qmail 90403 invoked by uid 500); 5 May 2015 22:24:32 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 90349 invoked by uid 500); 5 May 2015 22:24:32 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 90319 invoked by uid 99); 5 May 2015 22:24:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 22:24:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 092011DBE80; Tue, 5 May 2015 22:24:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8606451254768102340==" MIME-Version: 1.0 Subject: Re: Review Request 33608: Added a status update throughput benchmark. From: "Ben Mahler" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Kevin Sweeney" , "Aurora ReviewBot" , "Ben Mahler" , "Aurora" Date: Tue, 05 May 2015 22:24:31 -0000 Message-ID: <20150505222431.20177.63025@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/33608/ X-Sender: "Ben Mahler" References: <20150430003514.26756.18777@reviews.apache.org> In-Reply-To: <20150430003514.26756.18777@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: aurora --===============8606451254768102340== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ ----------------------------------------------------------- (Updated May 5, 2015, 10:24 p.m.) Review request for Aurora and Maxim Khutornenko. Changes ------- Added a maybeSleep() per Bill's request. Bugs: AURORA-1283 https://issues.apache.org/jira/browse/AURORA-1283 Repository: aurora Description ------- In order to justify doing asynchronous batch acknowledgements and to better understand status update throughput, this introduces a benchmark. Note that this assumes that status update processing is not synchronous, so that the benchmark doesn't need to be updated for AURORA-1228. Diffs (updated) ----- src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java c54619f7cd617b48069363173dcf63b6254b4095 src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java d7d659bb13f085ff06291ef0033572f8bdf29874 Diff: https://reviews.apache.org/r/33608/diff/ Testing ------- Ran the benchmarks against the existing code and some pending code I have for AURORA-1228 to demonstrate the improvement. The end to end tests are broken, appears to be unrelated to my change from what I can tell. Thanks, Ben Mahler --===============8606451254768102340==--