aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 34739: Adding ChainedPathDetector into the GC executor.
Date Thu, 28 May 2015 00:26:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85478
-----------------------------------------------------------

Ship it!



src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py
<https://reviews.apache.org/r/34739/#comment137055>

    Consider using PyHamcrest here, specifically  http://pyhamcrest.readthedocs.org/en/release-1.8/object_matchers/#hamcrest.core.core.isinstanceof.instance_of
with http://pyhamcrest.readthedocs.org/en/release-1.8/integration/#module-hamcrest.library.integration.match_equality


- Kevin Sweeney


On May 27, 2015, 5:03 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 5:03 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-1025
>     https://issues.apache.org/jira/browse/AURORA-1025
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
> 
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201

>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4

>   src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88

>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c

> 
> Diff: https://reviews.apache.org/r/34739/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast  src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message