aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 34484: Daemonize all deadline calls in aurora executor.
Date Tue, 26 May 2015 20:43:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34484/
-----------------------------------------------------------

(Updated May 26, 2015, 8:43 p.m.)


Review request for Aurora, Joe Smith and Vinod Kone.


Changes
-------

Propagate exceptions raised during stop and log them.


Bugs: AURORA-698
    https://issues.apache.org/jira/browse/AURORA-698


Repository: aurora


Description
-------

Daemonize all deadline calls in aurora executor.  If we do not daemonize, it's possible for
the aurora executor to send TASK_KILLED and then block indefinitely on shutdown.  This way
the aurora executor process will at least exit, allow the cgroup to tear down all active processes.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/aurora_executor.py df0df0cba3269a137a370e2b4096fd61fd3af258


Diff: https://reviews.apache.org/r/34484/diff/


Testing
-------

./pants test src/test/python/apache/aurora/executor::


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message