aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 34568: run tasks as user that match aurora-role
Date Fri, 22 May 2015 01:59:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34568/#review84851
-----------------------------------------------------------


This change lgtm but I will need to ask you to do the following things:
1. Remove wfarner from this review as currently he is on vacation. I suggest adding kevints
or jcohen.
2. Assign the ticket linked to this review to yourself and link to this review in the comments
of the ticket.
3. Confirm the e2e tests work with this change.

- Zameer Manji


On May 21, 2015, 2:54 p.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34568/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 2:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1237
>     https://issues.apache.org/jira/browse/AURORA-1237
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The tasks inside container should run as user that match aurora-role, if
> --nosetuid option is not passed for executor.
> 
> Testing Done:
>     ./pants test.pytest --no-fast --options='--verbose' src/test/python::
> 
> Bugs closed: AURORA-1237
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 
> 
> Diff: https://reviews.apache.org/r/34568/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message