aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 34373: Exposing task reconciliation stats.
Date Tue, 19 May 2015 22:22:57 GMT


> On May 19, 2015, 9:46 p.m., Ben Mahler wrote:
> > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, lines 214-217
> > <https://reviews.apache.org/r/34373/diff/2/?file=963238#file963238line214>
> >
> >     Any reason not to pass the '`reason`' directly, rather than passing the whole
`TaskStatus`?

Just making the helper method more useful by offloading all name extracting logic into it
making the consumer code cleaner.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34373/#review84394
-----------------------------------------------------------


On May 18, 2015, 10:42 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34373/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 10:42 p.m.)
> 
> 
> Review request for Aurora, Ben Mahler and Zameer Manji.
> 
> 
> Bugs: AURORA-1047
>     https://issues.apache.org/jira/browse/AURORA-1047
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding counters for the new `StatusChangeResult` values.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f1e5dd2d47af2570f404d198b3fbdd754174206e

>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f4631c1cec4386d813d5869c28289207acf8523f

> 
> Diff: https://reviews.apache.org/r/34373/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message