aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 34372: Place api_util.py inside a `pants_library` target.
Date Mon, 18 May 2015 21:07:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34372/#review84219
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On May 18, 2015, 9:05 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34372/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 9:05 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1325
>     https://issues.apache.org/jira/browse/AURORA-1325
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This places `api_util.py` inside a `pants_library` target and has the two consumer targets
depend on that file explicitly.
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/BUILD 885e610a640f96583189d9b0f88c96efff0aa106 
>   src/test/python/apache/aurora/admin/BUILD 89cd875c4fe9af3c18b15320ae1e1adfaede11fd

>   src/test/python/apache/aurora/client/cli/BUILD 5d922965dfbaf2eb0dc938e3d4d13f4cacb49627

> 
> Diff: https://reviews.apache.org/r/34372/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast --options='-v' src/test/python::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message