aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33959: Add update watch and update start --watch flag.
Date Fri, 08 May 2015 00:06:57 GMT


> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > <https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122>
> >
> >     Suggest "--wait-until" for consistency with job create command.

`--wait-until` accepts states, while this is a flag.  IMHO the name should match the behavior.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
-----------------------------------------------------------


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
>     https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32

>   src/main/python/apache/aurora/client/cli/update.py 8296db5434276910fc4f8470c7a962a8e8e0a9c2

>   src/test/python/apache/aurora/client/cli/test_supdate.py 6fb1f71b7dc787c090fce7b8e7c51baee862f336

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 501d111f444487dbaff8b6f22ffc67a9720b4dad

> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> -------
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message