aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 33705: Don't retry API requests that fail with auth errors.
Date Mon, 04 May 2015 17:54:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/#review82405
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On April 30, 2015, 5:12 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33705/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 5:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1248
>     https://issues.apache.org/jira/browse/AURORA-1248
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The only thing i really don't care for in this patch is that `add_auth_error_handler`
alters a 'private' field, but i was unable to come up with an alternative that wouldn't seem
to spiral into a refactor.  Advice/opinions solicited.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 3f9c691056ee50103a7857bea43160c75388f2aa

>   src/main/python/apache/aurora/client/cli/__init__.py 10d943215282a83ebe0cadac1592848d797c3e79

>   src/main/python/apache/aurora/client/cli/context.py adbffc4aa07c242691e87e0fcfc9f5b840999d1d

>   src/main/python/apache/aurora/common/transport.py eefe8f7b50e0e0040e28ff47b226e91316f1911e

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 9319728d3a95b158cb734f4cbc6be97187d43def

>   src/test/python/apache/aurora/client/cli/test_context.py d63f060ea6cf747792f27499da901dd7cecae596

>   src/test/python/apache/aurora/common/test_transport.py e4f93ef9dd6bf0d54166bdf6afb247fad871ea10

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh cc7cdee42b7c03dd1f121963129d94e67cb9e2a2

> 
> Diff: https://reviews.apache.org/r/33705/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message