Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============0394018637981399210=="
MIME-Version: 1.0
Subject: Re: Review Request 33608: Added a status update throughput benchmark.
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Maxim Khutornenko" <maxim@apache.org>
Cc: "Bill Farner" <wfarner@apache.org>,
 "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Aurora" <reviews@aurora.apache.org>
Date: Thu, 30 Apr 2015 00:35:02 -0000
Message-ID: <20150430003502.26755.62649@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
References: <20150429223128.17829.52453@reviews.apache.org>
In-Reply-To: <20150429223128.17829.52453@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>

--===============0394018637981399210==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On April 29, 2015, 10:31 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java, line 45
> > <https://reviews.apache.org/r/33608/diff/3/?file=945461#file945461line45>
> >
> >     If anything, you should expose Scheduler.class to hide the implementation.  This should allow you to revert changes in MesosSchedulerImpl.java.

Done.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33608/#review82048
-----------------------------------------------------------


On April 29, 2015, 6:12 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33608/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 6:12 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1283
>     https://issues.apache.org/jira/browse/AURORA-1283
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In order to justify doing asynchronous batch acknowledgements and to better understand status update throughput, this introduces a benchmark.
> 
> Note that this assumes that status update processing is not synchronous, so that the benchmark doesn't need to be updated for AURORA-1228.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java c54619f7cd617b48069363173dcf63b6254b4095 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 9b8ab7c1027731f9d3f6cae77b85272ea63354d4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java d7d659bb13f085ff06291ef0033572f8bdf29874 
> 
> Diff: https://reviews.apache.org/r/33608/diff/
> 
> 
> Testing
> -------
> 
> Ran the benchmarks against the existing code and some pending code I have for AURORA-1228 to demonstrate the improvement.
> 
> The end to end tests are broken, appears to be unrelated to my change from what I can tell.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


--===============0394018637981399210==--