Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10FD8173BD for ; Wed, 29 Apr 2015 03:33:38 +0000 (UTC) Received: (qmail 42161 invoked by uid 500); 29 Apr 2015 03:33:38 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 42108 invoked by uid 500); 29 Apr 2015 03:33:37 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 42089 invoked by uid 99); 29 Apr 2015 03:33:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2015 03:33:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 315941DBA81; Wed, 29 Apr 2015 03:33:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0257546883501525423==" MIME-Version: 1.0 Subject: Re: Review Request 33659: Add support for shorthand names of security realm modules. From: "Aurora ReviewBot" To: "Kevin Sweeney" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Wed, 29 Apr 2015 03:33:38 -0000 Message-ID: <20150429033338.26755.42924@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/33659/ X-Sender: "Aurora ReviewBot" References: <20150429031712.17829.41468@reviews.apache.org> In-Reply-To: <20150429031712.17829.41468@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============0257546883501525423== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/#review81924 ----------------------------------------------------------- Master (e311dbe) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 29, 2015, 3:17 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33659/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 3:17 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-1290 > https://issues.apache.org/jira/browse/AURORA-1290 > > > Repository: aurora > > > Description > ------- > > I initially went down the path of a custom `Parser` that extended `ModuleParser`, but it turns out that doesn't work. Parsers are identified by type, and a specific parser on the `@CmdLine` arg would have to reimplement the guts of `SetParser`. As a result, i decided it was more sane to bake the shorthand list in our canonical parser of modules. > > > Diffs > ----- > > docs/security.md db2e92495661800ef513334568810f16fcf513e1 > examples/vagrant/upstart/aurora-scheduler-kerberos.conf ef502b7dcc48c716f71ab5ce920084917564f6ff > src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java c96821683b4569977d6d2b8ed657b0625bdd1903 > > Diff: https://reviews.apache.org/r/33659/diff/ > > > Testing > ------- > > TODO(wfarner): Verify in end-to-end tests. > > > Thanks, > > Bill Farner > > --===============0257546883501525423==--