Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============2062433705465253125=="
MIME-Version: 1.0
Subject: Re: Review Request 33608: Added a status update throughput benchmark.
From: "Kevin Sweeney" <kevints@apache.org>
To: "Maxim Khutornenko" <maxim@apache.org>
Cc: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Kevin Sweeney" <kevints@apache.org>, "Aurora" <reviews@aurora.apache.org>
Date: Tue, 28 Apr 2015 01:30:33 -0000
Message-ID: <20150428013033.26755.96861@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Kevin Sweeney" <noreply@reviews.apache.org>
References: <20150428005721.17829.61477@reviews.apache.org>
In-Reply-To: <20150428005721.17829.61477@reviews.apache.org>
Reply-To: "Kevin Sweeney" <kevints@apache.org>

--===============2062433705465253125==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33608/#review81768
-----------------------------------------------------------


src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java
<https://reviews.apache.org/r/33608/#comment132228>

    You probably want http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/Uninterruptibles.html#sleepUninterruptibly(long,%20java.util.concurrent.TimeUnit) here.


- Kevin Sweeney


On April 27, 2015, 5:57 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33608/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 5:57 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1283
>     https://issues.apache.org/jira/browse/AURORA-1283
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In order to justify doing asynchronous batch acknowledgements and to better understand status update throughput, this introduces a benchmark.
> 
> Note that this assumes that status update processing is not synchronous, so that the benchmark doesn't need to be updated for AURORA-1228.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeCommand.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java 45de15a57baf7a2f7d437b590935714e28777f35 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeUncaughtExceptionHandler.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java c54619f7cd617b48069363173dcf63b6254b4095 
>   src/main/java/org/apache/aurora/scheduler/mesos/Driver.java c7e45a89ceaa2c310feb610091eec0b04187860e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 9b8ab7c1027731f9d3f6cae77b85272ea63354d4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java d7d659bb13f085ff06291ef0033572f8bdf29874 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java da2d5df2e053e6e1b8fb08d6813dff9eac9777f8 
> 
> Diff: https://reviews.apache.org/r/33608/diff/
> 
> 
> Testing
> -------
> 
> Ran the benchmarks against the existing code and some pending code I have for AURORA-1228 to demonstrate the improvement.
> 
> The end to end tests are broken, appears to be unrelated to my change from what I can tell.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


--===============2062433705465253125==--