Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69944175DC for ; Thu, 23 Apr 2015 00:24:50 +0000 (UTC) Received: (qmail 56413 invoked by uid 500); 23 Apr 2015 00:24:50 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 56355 invoked by uid 500); 23 Apr 2015 00:24:50 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 56334 invoked by uid 99); 23 Apr 2015 00:24:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 00:24:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5B1CE1DB62A; Thu, 23 Apr 2015 00:24:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7667083529681151274==" MIME-Version: 1.0 Subject: Review Request 33458: Implementing PendingTaskProcessor benchmark. From: "Maxim Khutornenko" To: "Bill Farner" Cc: "Maxim Khutornenko" , "Aurora" Date: Thu, 23 Apr 2015 00:24:51 -0000 Message-ID: <20150423002451.2947.40873@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/33458/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora --===============7667083529681151274== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/ ----------------------------------------------------------- Review request for Aurora and Bill Farner. Repository: aurora Description ------- Adjusting preemptor benchmark to test the correct functionality. ``` Benchmark (numPendingTasks) Mode Cnt Score Error Units SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 52.245 ± 3.140 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 10 thrpt 10 49.447 ± 1.606 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 100 thrpt 10 49.996 ± 2.105 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1000 thrpt 10 48.325 ± 1.710 ops/s ``` Diffs ----- src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java 8f43bd7068f3647fb2df22c60e913367924e2262 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 12f42a92a28c68fcc55bf2f0b130ffed8c4d4879 src/jmh/java/org/apache/aurora/benchmark/Tasks.java b4da057d658586f5e96c871a836011cb7a08d5d9 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java 4427115ceee0e5f3ca32462e3cfb2ad2f0ece913 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 156bac2d8cf941bcda0474ef75c7eaec74a39a3a Diff: https://reviews.apache.org/r/33458/diff/ Testing ------- ./gradlew jmh Thanks, Maxim Khutornenko --===============7667083529681151274==--