Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============5587917015369447297=="
MIME-Version: 1.0
Subject: Review Request 33455: Use "a" mode instead of "w" when opening stdout
 and stderr.
From: "Kevin Sweeney" <kevints@apache.org>
To: "Brian Wickman" <wickman@apache.org>
Cc: "Kevin Sweeney" <kevints@apache.org>, "Aurora" <reviews@aurora.apache.org>
Date: Wed, 22 Apr 2015 22:47:58 -0000
Message-ID: <20150422224758.2948.87982@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Kevin Sweeney" <noreply@reviews.apache.org>
Reply-To: "Kevin Sweeney" <kevints@apache.org>

--===============5587917015369447297==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33455/
-----------------------------------------------------------

Review request for Aurora and Brian Wickman.


Repository: aurora


Description
-------

Use "a" mode instead of "w" when opening stdout and stderr.

This allows an external log rotation process to truncate stdout and stderr without causing the creation of a sparse file.


Diffs
-----

  src/main/python/apache/thermos/core/process.py 5ce138dab161d880c0bd58b87a6f5a54d4ca2f99 

Diff: https://reviews.apache.org/r/33455/diff/


Testing
-------

With "w" mode testfile is 300 bytes despite being truncated externally.
```
% python 3> testfile
Python 2.7.6 (default, Sep  9 2014, 15:04:36)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> f = os.fdopen(3, 'w')
>>> f.write(100 * 'a')
>>> f.flush()

% echo -n '' > testfile

>>> f.write(200 * 'b')
>>> f.flush()
% ls -l testfile
-rw-r--r--  1 ksweeney  staff  300 Apr 22 15:40 testfile
```

With "a" mode testfile is 200 bytes.
```
% python 3> testfile
Python 2.7.6 (default, Sep  9 2014, 15:04:36)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> f = os.fdopen(3, 'a')
>>> f.write(100 * 'a')
>>> f.flush()

% echo -n '' > testfile

>>> f.write(200 * 'b')
>>> f.flush()

% ls -l testfile
-rw-r--r--  1 ksweeney  staff  200 Apr 22 15:40 testfile
```


Thanks,

Kevin Sweeney


--===============5587917015369447297==--