Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8115C17284 for ; Tue, 14 Apr 2015 19:19:35 +0000 (UTC) Received: (qmail 72332 invoked by uid 500); 14 Apr 2015 19:19:35 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 72281 invoked by uid 500); 14 Apr 2015 19:19:35 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 72263 invoked by uid 99); 14 Apr 2015 19:19:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2015 19:19:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 22B811D92F1; Tue, 14 Apr 2015 19:19:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6943566178729967377==" MIME-Version: 1.0 Subject: Re: Review Request 33184: Implement missing != operator for AuroraJobKey From: "Stephan Erb" To: "Bill Farner" , "Stephan Erb" , "Aurora" Date: Tue, 14 Apr 2015 19:19:36 -0000 Message-ID: <20150414191936.31554.2612@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Stephan Erb" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/33184/ X-Sender: "Stephan Erb" References: <20150414185301.31554.4565@reviews.apache.org> In-Reply-To: <20150414185301.31554.4565@reviews.apache.org> Reply-To: "Stephan Erb" X-ReviewRequest-Repository: aurora --===============6943566178729967377== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 14, 2015, 8:53 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/common/test_aurora_job_key.py, line 25 > > > > > > Can you test the inverse as well - keys that are not equal? Added. It is a little bit longer as we have to test all combinations. - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33184/#review80079 ----------------------------------------------------------- On April 14, 2015, 9:18 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33184/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 9:18 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Implement missing != operator for AuroraJobKey > > From the Python docu of __ne__: "There are no implied relationships among the comparison operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining __eq__(), one should also define __ne__() so that the operators will behave as expected." > > > Diffs > ----- > > src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce > src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1 > > Diff: https://reviews.apache.org/r/33184/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common:: > > > Thanks, > > Stephan Erb > > --===============6943566178729967377==--