Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 456291752F for ; Mon, 13 Apr 2015 19:40:37 +0000 (UTC) Received: (qmail 79777 invoked by uid 500); 13 Apr 2015 19:40:37 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 79731 invoked by uid 500); 13 Apr 2015 19:40:37 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 79702 invoked by uid 99); 13 Apr 2015 19:40:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2015 19:40:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 156291D9A1B; Mon, 13 Apr 2015 19:40:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5465782178784707269==" MIME-Version: 1.0 Subject: Re: Review Request 33103: Skip known flaky tests. From: "Bill Farner" To: "Joshua Cohen" , "Brian Wickman" Cc: "Bill Farner" , "Aurora" Date: Mon, 13 Apr 2015 19:40:38 -0000 Message-ID: <20150413194038.31554.35118@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/33103/ X-Sender: "Bill Farner" References: <20150413153203.31554.97339@reviews.apache.org> In-Reply-To: <20150413153203.31554.97339@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============5465782178784707269== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 13, 2015, 3:32 p.m., Brian Wickman wrote: > > Actually could you also mark test_integration_quitquitquit as well? I was trying to address it in https://reviews.apache.org/r/32221/diff/# but don't feel particularly confident about that approach. Done. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79882 ----------------------------------------------------------- On April 11, 2015, 5:16 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33103/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 5:16 p.m.) > > > Review request for Aurora, Joshua Cohen and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage. > > > Diffs > ----- > > src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e > src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 > src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1 > > Diff: https://reviews.apache.org/r/33103/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============5465782178784707269==--