Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C3E917A83 for ; Mon, 6 Apr 2015 20:30:41 +0000 (UTC) Received: (qmail 66450 invoked by uid 500); 6 Apr 2015 20:30:41 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 66389 invoked by uid 500); 6 Apr 2015 20:30:40 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 66358 invoked by uid 99); 6 Apr 2015 20:30:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Apr 2015 20:30:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AF0D21D73E5; Mon, 6 Apr 2015 20:30:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8776721567630540789==" MIME-Version: 1.0 Subject: Review Request 32900: Remove url related methods out of AuroraCommandContext From: "Zameer Manji" To: "Bill Farner" Cc: "Zameer Manji" , "Aurora" Date: Mon, 06 Apr 2015 20:30:38 -0000 Message-ID: <20150406203038.5638.6993@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32900/ X-Sender: "Zameer Manji" Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============8776721567630540789== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32900/ ----------------------------------------------------------- Review request for Aurora and Bill Farner. Repository: aurora Description ------- This is a refactor of AuroraCommandContext which removes all url related methods out of it. The objective of this refactor is to remove functionality from AuroraCommandContext to allow for easier testing of commands. This commit also adds two tests for commands which were using the url related functionality but lacked test coverage. Diffs ----- src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e src/test/python/apache/aurora/client/cli/test_open.py c20649f5cada241d0f6e9ae5f88d300eac073517 src/test/python/apache/aurora/client/cli/test_restart.py 92aefe612dd59df75188fd7fc8cf080c9a878dde src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 Diff: https://reviews.apache.org/r/32900/diff/ Testing ------- ./pants test.pytest --no-fast src/test/python/apache/aurora/client/cli:: Thanks, Zameer Manji --===============8776721567630540789==--