Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECA5317AD1 for ; Fri, 3 Apr 2015 21:21:07 +0000 (UTC) Received: (qmail 30336 invoked by uid 500); 3 Apr 2015 21:21:07 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 30286 invoked by uid 500); 3 Apr 2015 21:21:07 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 30257 invoked by uid 99); 3 Apr 2015 21:21:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2015 21:21:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE6BE1D72C2; Fri, 3 Apr 2015 21:21:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8667808837041036839==" MIME-Version: 1.0 Subject: Re: Review Request 32559: Add Kerberos support to the scheduler From: "Aurora ReviewBot" To: "Joshua Cohen" , "Bill Farner" Cc: "Aurora" , "Kevin Sweeney" , "Aurora ReviewBot" Date: Fri, 03 Apr 2015 21:21:05 -0000 Message-ID: <20150403212105.16791.60014@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32559/ X-Sender: "Aurora ReviewBot" References: <20150403211914.16792.66046@reviews.apache.org> In-Reply-To: <20150403211914.16792.66046@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============8667808837041036839== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78834 ----------------------------------------------------------- This patch does not apply cleanly on master (05d75e5), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 3, 2015, 9:19 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32559/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 9:19 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-812 > https://issues.apache.org/jira/browse/AURORA-812 > > > Repository: aurora > > > Description > ------- > > Support authenticating to the scheduler API with Kerberos. > > > Diffs > ----- > > config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15 > examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99 > examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677 > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487 > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/32559/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh > > > Thanks, > > Kevin Sweeney > > --===============8667808837041036839==--