aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 33659: Add support for shorthand names of security realm modules.
Date Wed, 29 Apr 2015 03:33:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33659/#review81924
-----------------------------------------------------------


Master (e311dbe) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 29, 2015, 3:17 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33659/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 3:17 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1290
>     https://issues.apache.org/jira/browse/AURORA-1290
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I initially went down the path of a custom `Parser` that extended `ModuleParser`, but
it turns out that doesn't work.  Parsers are identified by type, and a specific parser on
the `@CmdLine` arg would have to reimplement the guts of `SetParser`.  As a result, i decided
it was more sane to bake the shorthand list in our canonical parser of modules.
> 
> 
> Diffs
> -----
> 
>   docs/security.md db2e92495661800ef513334568810f16fcf513e1 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf ef502b7dcc48c716f71ab5ce920084917564f6ff

>   src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java c96821683b4569977d6d2b8ed657b0625bdd1903

> 
> Diff: https://reviews.apache.org/r/33659/diff/
> 
> 
> Testing
> -------
> 
> TODO(wfarner): Verify in end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message