aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 33608: Added a status update throughput benchmark.
Date Wed, 29 Apr 2015 00:48:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33608/
-----------------------------------------------------------

(Updated April 29, 2015, 12:48 a.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
-------

Review feedback.


Bugs: AURORA-1283
    https://issues.apache.org/jira/browse/AURORA-1283


Repository: aurora


Description
-------

In order to justify doing asynchronous batch acknowledgements and to better understand status
update throughput, this introduces a benchmark.

Note that this assumes that status update processing is not synchronous, so that the benchmark
doesn't need to be updated for AURORA-1228.


Diffs (updated)
-----

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeCommand.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java c54619f7cd617b48069363173dcf63b6254b4095

  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 9b8ab7c1027731f9d3f6cae77b85272ea63354d4

  src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java d7d659bb13f085ff06291ef0033572f8bdf29874


Diff: https://reviews.apache.org/r/33608/diff/


Testing
-------

Ran the benchmarks against the existing code and some pending code I have for AURORA-1228
to demonstrate the improvement.

The end to end tests are broken, appears to be unrelated to my change from what I can tell.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message