aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
Date Tue, 28 Apr 2015 18:06:58 GMT


> On April 28, 2015, 5:13 p.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java, line 128
> > <https://reviews.apache.org/r/33611/diff/1/?file=943491#file943491line128>
> >
> >     This benchmark is nearly identical to the role summary one. Any chance they
could share common definitions?

Thanks for the nudge.  I extracted a helper to perform most of `setUp()`.  I'd prefer to keep
the `@Param` independent, though, so each benchmark can define its own.  This may mean they
each use their own equivalent of `TestConfiguration` in the future.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33611/#review81836
-----------------------------------------------------------


On April 28, 2015, 12:57 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33611/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 12:57 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a benchmark for unscoped API task queries.
> 
> This change also makes it possible to run specific benchmarks.
> 
> I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`.
> 
> 
> Diffs
> -----
> 
>   build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8

>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696

>   src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8

> 
> Diff: https://reviews.apache.org/r/33611/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message