aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 33243: Use explicit status update acknowledgements.
Date Mon, 27 Apr 2015 23:47:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33243/#review81752
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java
<https://reviews.apache.org/r/33243/#comment132198>

    One more comment for upstream here - using the Builder pattern to construct a MesosSchedulerDriver
instead of overloaded constructors would allow all framework writers to avoid this.


- Kevin Sweeney


On April 27, 2015, 4:14 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33243/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 4:14 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1228
>     https://issues.apache.org/jira/browse/AURORA-1228
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The scheduler now explicitly acknowledges updates. I left the structure as is, per Bill's
suggestion.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java db7aa74c2dfca3d520d978d7837d1f2639e6c05c

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java f40746b5712f21e551c06eeb1aa379ebdcdbc693

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 4ef23ea6ebd2c9587a8356507fcb49a36b9de219

> 
> Diff: https://reviews.apache.org/r/33243/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests and the end-to-end test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message