aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 33537: Document Aurora security features.
Date Mon, 27 Apr 2015 23:24:06 GMT


> On April 27, 2015, 12:52 p.m., Bill Farner wrote:
> > Overall LGTM.
> > 
> > Can you link to this page from `deploying-aurora-scheduler.md`?

done.


> On April 27, 2015, 12:52 p.m., Bill Farner wrote:
> > docs/security.md, line 5
> > <https://reviews.apache.org/r/33537/diff/1/?file=941415#file941415line5>
> >
> >     A table of contents would be nice, and match other files.

Done.


> On April 27, 2015, 12:52 p.m., Bill Farner wrote:
> > docs/security.md, lines 57-58
> > <https://reviews.apache.org/r/33537/diff/1/?file=941415#file941415line57>
> >
> >     The merits of strong passwords is not lost on me, but i don't think it should
be the job of this document.  Noting that these are plaintext/raw is good, but beyond that
i think it's out of scope.

Dropped.


> On April 27, 2015, 12:52 p.m., Bill Farner wrote:
> > docs/security.md, line 151
> > <https://reviews.apache.org/r/33537/diff/1/?file=941415#file941415line151>
> >
> >     Is an equivalent change to clusters.json needed for basic auth?  Even if not,
it's worth calling out.

Pointed it out.


> On April 27, 2015, 12:52 p.m., Bill Farner wrote:
> > docs/security.md, line 201
> > <https://reviews.apache.org/r/33537/diff/1/?file=941415#file941415line201>
> >
> >     Markdown didn't like the format example here.

Fixed.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33537/#review81722
-----------------------------------------------------------


On April 27, 2015, 4:16 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33537/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 4:16 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-817
>     https://issues.apache.org/jira/browse/AURORA-817
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> SSIA
> 
> A rendered version is available on github as https://github.com/kevints/aurora/blob/kts/security-docs/docs/security.md
- feel free to send pull requests to fix typos, etc, from the markdown editor there and I
will incorporate them into this review.
> 
> 
> Diffs
> -----
> 
>   docs/security.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message