aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 33600: Extract an abstract base test for TaskStore implementations.
Date Mon, 27 Apr 2015 22:54:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33600/#review81742
-----------------------------------------------------------

Ship it!


Master (94fe6c9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 27, 2015, 10:26 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33600/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 10:26 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Another step towards a DB task store implementation.
> 
> I renamed `MemTaskStoreTest` to `InMemTaskStoreTest` to prove that the delta here is
small.  Otherwise, git will not treat the bulk of the change as a rename.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java fbdbb05b76f588a1e024c3f965013da4c7f1f982

>   src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 88fd006fc1d5b55ad957f2f232682d61c74e76b7

>   src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 688a02f8c827d5185e35ae2ec919dd0ae5b958ec

> 
> Diff: https://reviews.apache.org/r/33600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message