aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.
Date Fri, 24 Apr 2015 19:08:58 GMT


> On April 24, 2015, 6:35 p.m., Bill Farner wrote:
> > Ping - Maxim, can you check my replies above?
> 
> Maxim Khutornenko wrote:
>     >My plan is to avoid changing behavior with the task store, so i did not have
any intention of removing fields.
>     
>     Sorry, I was under assumption your decided to address the "user" part. Not storing
it in H2 means changing the current behavior, which I thought you wanted to avoid?

Now i'm confused.  The user is stored, causing behavior to be preserved.
```
creator_user VARCHAR NOT NULL,
```


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33279/#review81512
-----------------------------------------------------------


On April 16, 2015, 10 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33279/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 10 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-556
>     https://issues.apache.org/jira/browse/AURORA-556
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add SQL tables needed for a datbase-backed task store.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql ed73ef7a25537f145910dba7a1985805b3979173

> 
> Diff: https://reviews.apache.org/r/33279/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message