aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 33366: Fix the path to download stdout/stderr
Date Tue, 21 Apr 2015 19:07:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33366/#review81042
-----------------------------------------------------------

Ship it!



src/test/python/apache/thermos/observer/http/test_file_browser.py
<https://reviews.apache.org/r/33366/#comment131262>

    Please remove `int(x)` and replace it with `x` everywhere in this file.


- Zameer Manji


On April 21, 2015, 11:53 a.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33366/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 11:53 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1135
>     https://issues.apache.org/jira/browse/AURORA-1135
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Download url for stdout/stderr broken Make it relative to sandbox.
>     
> Testing Done:
>     ./pants test.pytest --no-fast --options='--verbose' src/test/python::
>     
> Bugs closed: AURORA-1135
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee

>   src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message