aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 33317: Upgrade to pystachio 0.8.0
Date Mon, 20 Apr 2015 19:17:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33317/
-----------------------------------------------------------

(Updated April 20, 2015, 7:17 p.m.)


Review request for Aurora, Brian Brazil and Joshua Cohen.


Changes
-------

Adds a 0.7.x <-> 0.8.x regression test.

With 0.7.4:

                     self = <[AttributeError("ChildOld has no attribute _scopes") raised
in repr()] SafeRepr object at 0x104d17a28>
                     attr = 'endpoint', value = '/health'
                     
                         def _process_schema_attribute(self, attr, value):
                           if attr not in self.TYPEMAP:
                     >       raise AttributeError('Unknown schema attribute %s' % attr)
                     E       AttributeError: Unknown schema attribute endpoint

With 0.8.0:

                     ============== test session starts ===============
                     platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
                     plugins: cov, timeout
                     collected 8 items 
                     
                     src/test/python/apache/aurora/config/test_base.py ........


Bugs: AURORA-1268
    https://issues.apache.org/jira/browse/AURORA-1268


Repository: aurora


Description
-------

Add pystachio 0.8.0 requirement.


Diffs (updated)
-----

  3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566 
  src/test/python/apache/aurora/config/test_base.py 66480db134cea97454d00e004bc3a1847cc5410f


Diff: https://reviews.apache.org/r/33317/diff/


Testing
-------

./pants test.pytest --no-fast --options='-v' src/test/python::


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message