aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.
Date Mon, 20 Apr 2015 18:05:30 GMT


> On April 20, 2015, 5:50 p.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 179
> > <https://reviews.apache.org/r/33279/diff/1/?file=932067#file932067line179>
> >
> >     What are your plans on retaining the "user" part of the Identity struct (AURORA-749)?
If you are planning to address it later a follow up TODO here would be nice to avoid dropping
this issue off the radar.

My plan is to avoid changing behavior with the task store, so i did not have any intention
of removing fields.


> On April 20, 2015, 5:50 p.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 200
> > <https://reviews.apache.org/r/33279/diff/1/?file=932067#file932067line200>
> >
> >     Isn't this too restrictive? Currently, we can still have something like 'rack':'limit:5'
and 'rack':'abc'. This constraint will now allow configs like that any longer.
> 
> Maxim Khutornenko wrote:
>     s/now/not

FWIW you actually can't do that due to AURORA-199.  I'm indifferent.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33279/#review80750
-----------------------------------------------------------


On April 16, 2015, 10 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33279/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 10 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-556
>     https://issues.apache.org/jira/browse/AURORA-556
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add SQL tables needed for a datbase-backed task store.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql ed73ef7a25537f145910dba7a1985805b3979173

> 
> Diff: https://reviews.apache.org/r/33279/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message