aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33317: Upgrade to pystachio 0.8.0
Date Fri, 17 Apr 2015 19:15:11 GMT


> On April 17, 2015, 6:22 p.m., Bill Farner wrote:
> > Can you include a test case proving that AURORA-1268 is fixed?
> 
> Brian Wickman wrote:
>     Shouldn't that be in the reapplication of 27a602d2?

It would be nice to tease apart the bug fix and the new feature.  I'm fine if the bug fix
comes separate from the version bump, so long as we don't claim success on AURORA-1268 without
proof in tests.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33317/#review80496
-----------------------------------------------------------


On April 17, 2015, 6:18 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33317/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 6:18 p.m.)
> 
> 
> Review request for Aurora, Brian Brazil and Joshua Cohen.
> 
> 
> Bugs: AURORA-1268
>     https://issues.apache.org/jira/browse/AURORA-1268
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add pystachio 0.8.0 requirement.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566 
> 
> Diff: https://reviews.apache.org/r/33317/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast --options='-v' src/test/python::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message