aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched
Date Tue, 14 Apr 2015 20:03:53 GMT


> On April 14, 2015, 12:58 p.m., Stephan Erb wrote:
> > Friendly ping. Anything still missing or is this ready to merge?

I don't think anything is missing. Waiting on jcohen to also give a shipit.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review80092
-----------------------------------------------------------


On April 11, 2015, 2:52 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 2:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1275
>     https://issues.apache.org/jira/browse/AURORA-1275
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Only perform escalation wait when http teardown signal could be dispatched
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021

>   src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50

>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908

> 
> Diff: https://reviews.apache.org/r/32889/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
> 
> In addition, manual verification that shutdown of health-checked services without lifecycle
methods is 10 seconds faster.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message