aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33184: Implement missing != operator for AuroraJobKey
Date Tue, 14 Apr 2015 18:53:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33184/#review80079
-----------------------------------------------------------



src/test/python/apache/aurora/common/test_aurora_job_key.py
<https://reviews.apache.org/r/33184/#comment129848>

    Can you test the inverse as well - keys that are not equal?


- Bill Farner


On April 14, 2015, 6:51 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33184/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 6:51 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement missing \!= operator for AuroraJobKey
> 
> From the Python docu of __ne__: "There are no implied relationships among the comparison
operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining
__eq__(), one should also define __ne__() so that the operators will behave as expected."
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce

>   src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1

> 
> Diff: https://reviews.apache.org/r/33184/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common::
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message