aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 33048: Add an end-to-end test for HTTP basic auth.
Date Fri, 10 Apr 2015 17:40:41 GMT


> On April 9, 2015, 7:09 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/aurora-scheduler.conf, line 46
> > <https://reviews.apache.org/r/33048/diff/1/?file=922110#file922110line46>
> >
> >     This file doesn't exist, causing the scheduler to fail startup.

Forgot to git add, should work now.


> On April 9, 2015, 7:09 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 56
> > <https://reviews.apache.org/r/33048/diff/1/?file=922111#file922111line56>
> >
> >     You can omit `-s` now.

didnt mean to make this change - reverted


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33048/#review79626
-----------------------------------------------------------


On April 10, 2015, 10:39 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33048/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 10:39 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-810
>     https://issues.apache.org/jira/browse/AURORA-810
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an end-to-end test for HTTP basic auth.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/aurorabuild.sh 47baa4eb2cfb4513146ec9aa938c2d7ded9cfb79 
>   examples/vagrant/provision-dev-cluster.sh e88efc357782df14e473673253a4c107fe873f4d

>   examples/vagrant/upstart/aurora-scheduler.conf 1090bd8559694a56cb92d6079e9b2a6c2c9c079b

>   src/dist/etc/shiro.example.ini PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f3c9d82888f9dfaa1cc57d5a199059b13d95e981

> 
> Diff: https://reviews.apache.org/r/33048/diff/
> 
> 
> Testing
> -------
> 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message