aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 33019: Added new (optional) paramter to ProcessBase for a statsd end-point, and submits a counter (increment) per "process.state" when statsd end-point provided
Date Fri, 10 Apr 2015 01:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33019/#review79615
-----------------------------------------------------------


Heads up - we can't add to the pystachio schema until we fix and come up with a plan to avoid
things like https://issues.apache.org/jira/browse/AURORA-1266

Expect a ticket linked against that one to track this.

- Bill Farner


On April 9, 2015, 4:38 p.m., Michael Schenck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33019/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 4:38 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> * Plotting "{Process.name()}.{ProcessState}" counter
> * Added unit test for writing state transitions to statsd end-point
> * Added "statsd" (optional) attribute to Process schema
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518

>   src/main/python/apache/thermos/core/process.py 5ce138dab161d880c0bd58b87a6f5a54d4ca2f99

>   src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa

>   src/test/python/apache/thermos/core/test_process.py 5e6ad2fca616b840299bd9ca1614c82c5c39e992

> 
> Diff: https://reviews.apache.org/r/33019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Schenck
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message