aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 32990: Improving JobUpdateDetails fetch performance.
Date Thu, 09 Apr 2015 19:15:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/
-----------------------------------------------------------

(Updated April 9, 2015, 7:15 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Fixed import ordering.


Bugs: AURORA-1263
    https://issues.apache.org/jira/browse/AURORA-1263


Repository: aurora


Description
-------

Using event collections with "select" avoids unnecessary row explosion and provdes subsecond
execution time for a large job update that used to take half a minute.

Before:
```
Benchmark                                      (instances)   Mode  Cnt   Score   Error  Units
UpdateStoreBenchmarks.JobDetailsBenchmark.run         1000  thrpt    5  15.595 ± 1.056
 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run         5000  thrpt    5   3.143 ± 0.259
 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run        10000  thrpt    5   1.539 ± 0.075
 ops/s
```

After:
```
Benchmark                                      (instances)   Mode  Cnt    Score    Error 
Units
UpdateStoreBenchmarks.JobDetailsBenchmark.run         1000  thrpt    5  278.405 ± 57.311
 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run         5000  thrpt    5   65.386 ±  6.455
 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run        10000  thrpt    5   33.353 ±  1.974
 ops/s
```


Diffs (updated)
-----

  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d


Diff: https://reviews.apache.org/r/32990/diff/


Testing
-------

./gradlew -Pq build
Manual testing in vagrant.


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message