aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 32900: Remove url related methods out of AuroraCommandContext
Date Tue, 07 Apr 2015 19:48:25 GMT


> On April 6, 2015, 5:16 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/cli/cron.py, line 116
> > <https://reviews.apache.org/r/32900/diff/1/?file=918253#file918253line116>
> >
> >     inline `url`.  ditto several other places in this diff.

Done.


> On April 6, 2015, 5:16 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/test_create.py, line 178
> > <https://reviews.apache.org/r/32900/diff/1/?file=918256#file918256line178>
> >
> >     should be +4 indent, here and elsewhere in this diff.

Done.


> On April 6, 2015, 5:16 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/base.py, line 176
> > <https://reviews.apache.org/r/32900/diff/1/?file=918251#file918251line176>
> >
> >     i have no strong opinion, but it feels odd to add `update_id` to this signature.
 consider keeping this signature, and implementing the suffix addition in `get_update_page`.

I did not revert the signature because update's are now first class entities in Aurora including
our URL structure. This function reflects that.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32900/#review79086
-----------------------------------------------------------


On April 7, 2015, 12:44 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32900/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 12:44 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a refactor of AuroraCommandContext which removes all url related methods out
of it. The objective of this refactor is to remove functionality from AuroraCommandContext
to allow for easier testing of commands. This commit also adds two tests for commands which
were using the url related functionality but lacked test coverage.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/base.py c72f2f700fd63f77f920d1e0e7f1183f08bd3906

>   src/main/python/apache/aurora/client/cli/context.py e75c6cb6c29727654e6bd06e4391abf2d7ae0f0a

>   src/main/python/apache/aurora/client/cli/cron.py 732135fa7c149140aed4d5c9ae0b8a2e4608c388

>   src/main/python/apache/aurora/client/cli/jobs.py 2d82942b70e6bc04c246809cb34197978c83e5b4

>   src/main/python/apache/aurora/client/cli/update.py 5f98fc27480e4ee104ce03acfbf091772e9ac7e5

>   src/test/python/apache/aurora/client/cli/test_create.py 57970c467bc5223467d78267bcd160f2d12f9116

>   src/test/python/apache/aurora/client/cli/test_cron.py 9fa176e35272a0b2eb30a246081e1b3526d207fb

>   src/test/python/apache/aurora/client/cli/test_kill.py 69d84022291617f3a28d269319c7135363e900ce

>   src/test/python/apache/aurora/client/cli/test_open.py 92f9c3d2c916e0dcbbba508ea5e5b756499631da

>   src/test/python/apache/aurora/client/cli/test_restart.py fb5491dc3e2ac3fd687edb1c819c4b399800e27a

>   src/test/python/apache/aurora/client/cli/util.py 291186b75103b570188b2782db543cff4d112273

> 
> Diff: https://reviews.apache.org/r/32900/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message