aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 32905: Remove factory.py
Date Tue, 07 Apr 2015 00:24:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32905/#review79091
-----------------------------------------------------------

Ship it!


Master (6fc7f58) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 7, 2015, 12:05 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32905/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 12:05 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch removes `src/main/python/apache/aurora/client/factory.py` which was a pile
of technical debt. By removing the indirection of creating client object the code is much
easier to understand. As a result of removing this file many tests had to be touched because
they were patching CLUSTERS via factory.py. The need to patch CLUSTERS at each test site was
removed and replaced by modifying `AuroraClientCommandTest` to patch CLUSTERS before running
any test. This approach is required because `FakeAuroraCommandContext` inherits from `AuroraCommandContext`
which causes the execute on import code in clusters.py to execute for each test.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/BUILD 7a100d1a4a74aae034082f34db051c9cc31f8540

>   src/main/python/apache/aurora/admin/admin.py d9ed66c490d7d8351fd1b37b83ae82830a304b0b

>   src/main/python/apache/aurora/client/BUILD bf196bf86b36db0d72f8e096260c9a900f74d07c

>   src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32

>   src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4

>   src/main/python/apache/aurora/client/factory.py 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65

>   src/test/python/apache/aurora/admin/test_admin_sla.py 225251baf54f4f181855014ae501d3d91a59a1ad

>   src/test/python/apache/aurora/client/BUILD 831a72d39b27ca2aca466a389140000bbf40ff94

>   src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649

>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2

>   src/test/python/apache/aurora/client/cli/test_cancel_update.py c15e142930c9474c7873dd931261b6ab4eb5967f

>   src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18

>   src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e

>   src/test/python/apache/aurora/client/cli/test_quota.py 88fb9aec4d1eae6ad05da01752a670f902bafb1b

>   src/test/python/apache/aurora/client/cli/test_restart.py 92aefe612dd59df75188fd7fc8cf080c9a878dde

>   src/test/python/apache/aurora/client/cli/test_sla.py a1a3d8161ba747aa23a5e614e9ae31473d2058c1

>   src/test/python/apache/aurora/client/cli/test_status.py 721d9764190bdc4b1c5b65e416a039803b7c507c

>   src/test/python/apache/aurora/client/cli/test_task.py 2580664ec913003e518b44a0278b8951b69e0504

>   src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a0000248cfe0a96458fb70c

>   src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904

>   src/test/python/apache/aurora/client/test_factory.py PRE-CREATION 
>   src/test/python/apache/aurora/client/util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32905/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message