aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 32896: Remove scheduler warning when maxWaitToInstanceRunningMs is set.
Date Mon, 06 Apr 2015 19:22:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32896/#review78969
-----------------------------------------------------------

Ship it!


Master (5587bce) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2015, 7:04 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32896/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 7:04 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1240
>     https://issues.apache.org/jira/browse/AURORA-1240
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is backing out a slice of https://reviews.apache.org/r/32840/
> 
> Turns out there's no sane way to have an 0.8.0 client that works with an 0.7.0 and 0.8.0
scheduler _and_ does not produce warnings for all updates.  As such, it's best to not send
a warning the user can't safely address.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 2cbbed0588449229cfe6b56f29fb97e467515ab0

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 73c46054e03b227481f6fcb6fe4333322af4fc58

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
9ae8f1aa820d3959b7589963bdaba468bd98889e 
> 
> Diff: https://reviews.apache.org/r/32896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message