aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 32840: Ignore maxWaitToInstanceRunningMs in the scheduler updater.
Date Mon, 06 Apr 2015 17:59:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32840/
-----------------------------------------------------------

(Updated April 6, 2015, 5:59 p.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
-------

Added a deprecation warning when the ignored field is set.


Bugs: AURORA-1240
    https://issues.apache.org/jira/browse/AURORA-1240


Repository: aurora


Description (updated)
-------

Ignore this field as it tends to cause confusion with little practical benefit (see ticket
for more justification).


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5588d1793d6713ee4581ac9f938d9a8689acb315

  src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 14753cf5ef35d5133ca5029f3a465df884756070

  src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 0f4913a941895b032b0649a4040a6cce1bd19856

  src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java 1590e12a6997f61cc3c97c4cf18476486967cea7

  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java b87ae4e08039c0505d6d2f35b6d746ef9897e433

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f5326af819744f2d4471fe67a065ae842372a579

  src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 09c147e76d7c2c130a1fdd85459c45395fee7dde

  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 312fd2b0381de82cd3b7ad1a0bde883e551cfee2


Diff: https://reviews.apache.org/r/32840/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message