aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 32597: Improving async preemptor efficiency.
Date Mon, 06 Apr 2015 17:52:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review78947
-----------------------------------------------------------

Ship it!


Inverting the loop is a great idea.


src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java
<https://reviews.apache.org/r/32597/#comment128063>

    A ticket should be filed to ensure we do not lose track of this improvement.


- Zameer Manji


On April 3, 2015, 1:04 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32597/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 1:04 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1219
>     https://issues.apache.org/jira/browse/AURORA-1219
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is addressing the preemption efficiency loss due to making preemptor async. Summary:
> - Implemented fair task processing by evaluating pending tasks in the order of their
TaskGroupKeys (largest count first)
> - Inverted the traversal of pending tasks to better reuse loop invariants. Every slave
is sized up against all pending tasks until a match is found
> - Moved relevant functionality from PreemptionSlotFinder (now PreemptionVictimFilter)
into PendingTaskProcessor.
> 
> The bulk of new functionality is in PendingTaskIterator and PendingTaskProcessor. The
rest is refactoring to adjust to the new traversal approach.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskIterator.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
67ad5d7f9909bc892301c19586561b6cdbfe79e6 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlot.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCache.java
b5a42a0a0498f06a382576e2c3a839bbb7f1d2b1 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java
427c0de205c28540b217e817bdbab10b4af5aee4 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 77617ec11119a2bcd062d5b80cd2b4c58dc80514

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 1092c055588363794b37a965fb2f17a6e50d92d7

>   src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java 6af3949b85297043640edccc1a490906c0fcff6c

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskIteratorTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
bcd1b4e854f5ea227268c73156bc97c7c937c1de 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCacheTest.java
80bd13a192bda64759b5a93749ec47ddfeae504a 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 281f4e02650727aa5d0a35a09dcf0eb823ad1b50

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java
b80e558f18b817814e4768b13ff94aa816d28543 
> 
> Diff: https://reviews.apache.org/r/32597/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Manual testing in vagrant
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message