Return-Path: 
 <reviews-return-8985-apmail-aurora-reviews-archive=aurora.apache.org@aurora.incubator.apache.org>
X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org
Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E6FB217E14
	for <apmail-aurora-reviews-archive@minotaur.apache.org>;
 Mon, 23 Mar 2015 18:50:49 +0000 (UTC)
Received: (qmail 8392 invoked by uid 500); 23 Mar 2015 18:50:43 -0000
Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org
Received: (qmail 8342 invoked by uid 500); 23 Mar 2015 18:50:43 -0000
Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@aurora.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@aurora.incubator.apache.org>
List-Post: <mailto:reviews@aurora.incubator.apache.org>
List-Id: <reviews.aurora.incubator.apache.org>
Reply-To: reviews@aurora.incubator.apache.org
Delivered-To: mailing list reviews@aurora.incubator.apache.org
Received: (qmail 8331 invoked by uid 99); 23 Mar 2015 18:50:43 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2015 18:50:43 +0000
X-ASF-Spam-Status: No, hits=-1997.8 required=5.0
	tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 23 Mar 2015 18:50:20 +0000
Received: (qmail 8223 invoked by uid 99); 23 Mar 2015 18:50:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2015 18:50:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 18ED31D46D4;
	Mon, 23 Mar 2015 18:50:17 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1953145022008921941=="
MIME-Version: 1.0
Subject: Re: Review Request 32377: Add a mechanism to lazily instantiate
 module
 classes.
From: "Bill Farner" <wfarner@apache.org>
To: "Kevin Sweeney" <kevints@apache.org>
Cc: "Bill Farner" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>
Date: Mon, 23 Mar 2015 18:50:17 -0000
Message-ID: <20150323185017.32591.29008@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
X-ReviewGroup: Aurora
X-ReviewRequest-URL: https://reviews.apache.org/r/32377/
X-Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20150323174332.32590.70093@reviews.apache.org>
In-Reply-To: <20150323174332.32590.70093@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>
X-ReviewRequest-Repository: aurora
X-Virus-Checked: Checked by ClamAV on apache.org

--===============1953145022008921941==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On March 23, 2015, 5:43 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 99
> > <https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line99>
> >
> >     Can you push this to ModuleParser?

Good call, done.


> On March 23, 2015, 5:43 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 61
> > <https://reviews.apache.org/r/32377/diff/1/?file=902302#file902302line61>
> >
> >     Can you push the lazy instantiation logic to ModuleParser and change this back to Arg<Set<Module>>?
> 
> Kevin Sweeney wrote:
>     To be clear I suggest defining
>     
>     ```java
>     private static final Arg<Set<Module>> SHIRO_REALM_MODULES = Arg.create(ImmutableSet.of(Modules.lazilyInstantiated(IniShiroRealmModule.class)));
>     ```

Done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77423
-----------------------------------------------------------


On March 22, 2015, 6:37 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32377/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 6:37 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1217
>     https://issues.apache.org/jira/browse/AURORA-1217
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an indirection for modules that must not be statically instantiated.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/Modules.java e95cb2a255e6986e0678a4085036deb24f9cb359 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java cc9cfd38239f909b8a77bd1a773e31ec30130d41 
>   src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


--===============1953145022008921941==--