Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 823F017589 for ; Fri, 20 Mar 2015 22:22:59 +0000 (UTC) Received: (qmail 45373 invoked by uid 500); 20 Mar 2015 22:22:54 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 45325 invoked by uid 500); 20 Mar 2015 22:22:54 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 45314 invoked by uid 99); 20 Mar 2015 22:22:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2015 22:22:54 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 Mar 2015 22:22:30 +0000 Received: (qmail 44290 invoked by uid 99); 20 Mar 2015 22:22:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2015 22:22:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6CB9C1D4674; Fri, 20 Mar 2015 22:22:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3120980148069314617==" MIME-Version: 1.0 Subject: Re: Review Request 32329: Extract job key from RPC parameters From: "Aurora ReviewBot" To: "Joshua Cohen" , "Bill Farner" Cc: "Aurora" , "Kevin Sweeney" , "Aurora ReviewBot" Date: Fri, 20 Mar 2015 22:22:27 -0000 Message-ID: <20150320222227.1489.64829@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32329/ X-Sender: "Aurora ReviewBot" References: <20150320220146.1490.89717@reviews.apache.org> In-Reply-To: <20150320220146.1490.89717@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3120980148069314617== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77286 ----------------------------------------------------------- Ship it! Master (f12d9fe) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 20, 2015, 10:01 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32329/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 10:01 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1187 > https://issues.apache.org/jira/browse/AURORA-1187 > > > Repository: aurora > > > Description > ------- > > Apologies for the large diff, this wound up needing to input validation at the AOP layer. > > Probably the best place to start reading this diff is ApiSecurityIT to see the feature this patch enables. > > Also the best place to start reviewing FieldGetterDag is also its tests and usage. > > > Diffs > ----- > > config/pmd/custom.xml 521fd500146eb2e45f8e77c5c3c0cce330fedabb > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 827e85b6cac8bd52359610bbc2002973a769705c > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 2408cd1f9af5f109a339f5c78134465cb117f7fc > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java cc9cfd38239f909b8a77bd1a773e31ec30130d41 > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java 808987939b2c4a850e488dc033b50b0178e95ba0 > src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDag.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthenticatingThriftInterceptor.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java 4e341e05c34b1be38f0040c26b671a0cc797a771 > src/main/java/org/apache/aurora/scheduler/http/api/security/StructFieldGetter.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/StructGetter.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/StructGetters.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5588d1793d6713ee4581ac9f938d9a8689acb315 > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java bdd2185f3a7a94b39bcec3c73455e970d87f0c6a > src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java cafd10f6b705568588c1b92644b482003242fe2e > src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java ed284f46ac8f01bd6d9e317f995f16d6e666a68d > src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 76cb691e6d7d4fada3a18fde73aceed7039bcaa4 > src/test/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDagTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthenticatingThriftInterceptorTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java d2ba2730c4509dc9a636fd32e9244b0d7fa2884f > src/test/java/org/apache/aurora/scheduler/http/api/security/StructFieldGetterTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 1f24e7d47e1f777ffef19a73d01171fcacd31cdb > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java d20c9da3c4944ec8c50fe8d48b7e459ff1c7082b > > Diff: https://reviews.apache.org/r/32329/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > > --===============3120980148069314617==--