Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFE1817327 for ; Fri, 20 Mar 2015 02:00:04 +0000 (UTC) Received: (qmail 82975 invoked by uid 500); 20 Mar 2015 02:00:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 82928 invoked by uid 500); 20 Mar 2015 02:00:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 82917 invoked by uid 99); 20 Mar 2015 02:00:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2015 02:00:04 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 Mar 2015 01:59:42 +0000 Received: (qmail 82534 invoked by uid 99); 20 Mar 2015 01:59:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2015 01:59:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 945A91D4655; Fri, 20 Mar 2015 01:59:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6265171124170658291==" MIME-Version: 1.0 Subject: Re: Review Request 32276: Fix error listing active updates. From: "Bill Farner" To: "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Fri, 20 Mar 2015 01:59:38 -0000 Message-ID: <20150320015938.392.53318@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32276/ X-Sender: "Bill Farner" References: <20150320015316.392.66246@reviews.apache.org> In-Reply-To: <20150320015316.392.66246@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6265171124170658291== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 20, 2015, 1:53 a.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 248 > > > > > > You can use frozenset here as well. It's a shame thrift sets are mutable by default (which causes them to be unhashable). Good call, done. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32276/#review77153 ----------------------------------------------------------- On March 20, 2015, 1:53 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32276/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 1:53 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > Fixes this error: > ``` > $ aurora update list devcluster/vagrant/test/http_example --status active > Traceback (most recent call last): > File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute > self.execute_entry(entry_point, args) > File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in execute_entry > runner(entry_point) > File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in execute_pkg_resources > runner() > File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, in proxy_main > File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 329, in execute > File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 306, in _execute > File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 382, in execute > File "apache/aurora/client/cli/update.py", line 315, in execute > TypeError: unhashable type: 'set' > ``` > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/update.py 2168e99a315dd2916086100589c8345cd3a2c4ff > > Diff: https://reviews.apache.org/r/32276/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============6265171124170658291==--